Fix SampleExtComputationInput() for non-varying computation inputs. #3704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the computation input was not time-sampled, the return value would be 0 causing callers to ignore the time sample of 0.0. This could then cause HdExtComputationUtils::SampleComputedPrimvarValues() to fail while executing the computation due to the non-varying inputs having no values. This was the same issue that 33dbdb1 fixed for SamplePrimvar()
Collaborator
|
Filed as internal issue #USD-11181 (This is an automated message. See here for more information.) |
meshula
pushed a commit
to meshula/USD
that referenced
this pull request
Sep 11, 2025
…ying computation inputs. This fixes failures in `HdExtComputationUtils::SampleComputedPrimvarValues()` we encountered when evaluating skinning computations in Hydra 2 If the computation input was not time-sampled, the return value would be 0 causing callers to ignore the time sample of 0.0. This could then cause `HdExtComputationUtils::SampleComputedPrimvarValues()` to fail while executing the computation due to the non-varying inputs having no values. This was the same issue that 33dbdb1 fixed for `SamplePrimvar()` Closes PixarAnimationStudios#3704 (Internal change: 2373889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This fixes failures in
HdExtComputationUtils::SampleComputedPrimvarValues()we encountered when evaluating skinning computations in Hydra 2If the computation input was not time-sampled, the return value would be 0 causing callers to ignore the time sample of 0.0. This could then cause
HdExtComputationUtils::SampleComputedPrimvarValues()to fail while executing the computation due to the non-varying inputs having no values.This was the same issue that 33dbdb1 fixed for
SamplePrimvar()Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)